qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Evgeny Voevodin <e.voevodin@samsung.com>,
	qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
	Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files
Date: Sat, 18 Feb 2012 16:53:56 +0100	[thread overview]
Message-ID: <4F3FC994.1040806@suse.de> (raw)
In-Reply-To: <CAAu8pHtP9Ef1GJ-nDZx_UuPzYUg+G2HdHfdUR7DwoDQtWip94A@mail.gmail.com>

Am 18.02.2012 10:13, schrieb Blue Swirl:
> One way to handle this is gradual reformatting, every time when code
> is touched, only changes towards common CODING_STYLE are allowed.

That's what we've been doing wrt braces and I appreciate us not
cluttering the history with reformatting commits.

Especially at a time where I'm touching every target (and seeing quite
some variations on coding style) I'm not so happy about this initiative.

> On Fri, Feb 17, 2012 at 15:26, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> I don't even want to consider something that touches every line of code.
>>  That's effectively creating a new source tree and losing the continuity of
>> our SCM history.
> 
> I think only 'git blame' output would be affected and that is not 100%
> reliable anyway, considering for example code movement.

I use repo.or.cz's blame function quite often to find out who to cc or
what commit to mention, and (valid) typo fixes are already troublesome,
requiring to go to the parent commit and to navigate to the same file in
its tree. One cannot specify any custom ignore options there.

Is there a better tool to do such interactive, recursive git-blame?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  parent reply	other threads:[~2012-02-18 15:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 14:59 [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files Andreas Färber
2012-02-09 15:03 ` Andreas Färber
2012-02-09 16:43 ` malc
2012-02-10  3:50 ` Evgeny Voevodin
2012-02-10  4:02   ` malc
2012-02-10 17:47     ` Anthony Liguori
2012-02-11  9:44       ` Blue Swirl
2012-02-17 14:31         ` Anthony Liguori
2012-02-17 14:55           ` Markus Armbruster
2012-02-17 15:26             ` Anthony Liguori
2012-02-18  9:13               ` Blue Swirl
2012-02-18 10:56                 ` Stefan Weil
2012-02-18 14:18                   ` Anthony Liguori
2012-02-18 14:34                     ` Blue Swirl
2012-02-18 15:53                 ` Andreas Färber [this message]
2012-02-18 16:47                   ` Eric Blake
2012-02-18  8:56           ` Blue Swirl
2012-02-18  9:07             ` [Qemu-devel] [PATCH] astyle: Formatting rules for QEMU Stefan Weil
2012-02-18 10:10               ` Blue Swirl
2012-02-18 11:13                 ` Stefan Weil
2012-02-11  9:37 ` [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3FC994.1040806@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=e.voevodin@samsung.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).