From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RyoRM-0006Y1-WA
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:51:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RyoRM-0005sr-3w
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:51:20 -0500
Received: from cantor2.suse.de ([195.135.220.15]:42795 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RyoRL-0005s9-VA
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:51:20 -0500
Message-ID: <4F3FE50C.40700@suse.de>
Date: Sat, 18 Feb 2012 18:51:08 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1329564636-29883-1-git-send-email-jcmvbkbc@gmail.com>
	<1329585103-31371-1-git-send-email-jcmvbkbc@gmail.com>
	<1329585103-31371-7-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1329585103-31371-7-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the
	watch_mem_write
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org

Thanks, incidentally:

Am 18.02.2012 18:11, schrieb Max Filippov:
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>

Reviewed-by is missing. Care to fix on your branch?

I don't see any Rb/Ab on the others as well, please check.

Andreas

> ---
>  exec.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
>=20
> diff --git a/exec.c b/exec.c
> index b81677a..f105b43 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3289,9 +3289,15 @@ static void watch_mem_write(void *opaque, target=
_phys_addr_t addr,
>  {
>      check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRI=
TE);
>      switch (size) {
> -    case 1: stb_phys(addr, val);
> -    case 2: stw_phys(addr, val);
> -    case 4: stl_phys(addr, val);
> +    case 1:
> +        stb_phys(addr, val);
> +        break;
> +    case 2:
> +        stw_phys(addr, val);
> +        break;
> +    case 4:
> +        stl_phys(addr, val);
> +        break;
>      default: abort();
>      }
>  }

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg