From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzOB3-0004u9-GM for qemu-devel@nongnu.org; Mon, 20 Feb 2012 03:00:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzOAu-0007Gz-4z for qemu-devel@nongnu.org; Mon, 20 Feb 2012 03:00:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzOAt-0007Gr-Sv for qemu-devel@nongnu.org; Mon, 20 Feb 2012 03:00:44 -0500 Message-ID: <4F41FD8E.60406@redhat.com> Date: Mon, 20 Feb 2012 09:00:14 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1329491433-31446-1-git-send-email-kraxel@redhat.com> <1329491433-31446-5-git-send-email-kraxel@redhat.com> <20120217193918.GH23926@garlic.redhat.com> In-Reply-To: <20120217193918.GH23926@garlic.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, spice-devel@lists.freedesktop.org Hi, > I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the > spice-protocol patch? Yes. >> - if (qxl->vram_size < 4096) { >> - qxl->vram_size = 4096; >> + if (qxl->vram_size < qxl->vram32_size) { >> + qxl->vram_size = qxl->vram32_size; > > Am I reading correctly that you want the 64bit bar to be at least the > size of the 32bit bar? why? The 64bit bar isn't additional memory. Both 32bit and 64bit bar are backed by the same memory, the 64bit bar is just a different way to access it. So it doesn't make sense at all to make the 64bit bar smaller than the 32bit bar. The other way around makes sense, to save address space below 4G. cheers, Gerd