From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzPHt-00023n-O9 for qemu-devel@nongnu.org; Mon, 20 Feb 2012 04:12:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzPHo-0003vZ-UO for qemu-devel@nongnu.org; Mon, 20 Feb 2012 04:12:01 -0500 Message-ID: <4F420E57.9090804@redhat.com> Date: Mon, 20 Feb 2012 10:11:51 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1329695347-9289-1-git-send-email-afaerber@suse.de> In-Reply-To: <1329695347-9289-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qom: Fix object_initialize_with_type() assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 02/20/2012 12:49 AM, Andreas F=C3=A4rber wrote: > Assert the object is at least sizeof(Object), not sizeof(ObjectClass). >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > qom/object.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/qom/object.c b/qom/object.c > index b1ead15..dbfd6a4 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -262,7 +262,7 @@ void object_initialize_with_type(void *data, TypeIm= pl *type) > Object *obj =3D data; > =20 > g_assert(type !=3D NULL); > - g_assert(type->instance_size >=3D sizeof(ObjectClass)); > + g_assert(type->instance_size >=3D sizeof(Object)); > =20 > type_class_init(type); > g_assert(type->abstract =3D=3D false); Reviewed-by: Paolo Bonzini Paolo