From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RzRcY-0002bV-06
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 06:41:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RzRcS-0000oI-4z
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 06:41:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52308)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RzRcR-0000oE-TU
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 06:41:24 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1KBfNJA015218
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 20 Feb 2012 06:41:23 -0500
Message-ID: <4F423155.1010706@redhat.com>
Date: Mon, 20 Feb 2012 12:41:09 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1329686886-6853-1-git-send-email-alevy@redhat.com>
	<1329686886-6853-8-git-send-email-alevy@redhat.com>
In-Reply-To: <1329686886-6853-8-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 7/7] qxl: add allocator
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org, elmarco@redhat.com

On 02/19/12 22:28, Alon Levy wrote:
> Add an implementation of the DisplayAllocator callbacks for qxl. Uses
> the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32
> bits per pixel line convertion. Since free/resize/create are defined in
> qxl.c, it is easy to ensure consistent usage of the flag (it means
> QXL_ALLOCATED basically).
> 
> With this patch and the previous two screendump works for vga and qxl
> modes when using qxl and spice together. This might break sdl/vnc with
> spice, untested since it isn't of known use.

Breaking vnc+spice being used in parallel breaking is exactly what I
suspect might be possible.  IIRC there where discussions about just
enabling both vnc+spice, then let users pick what to use, so I'd prefer
to not break this.

Setting the QEMU_ALLOCATED_FLAG flag sounds hackish too.

cheers,
  Gerd