From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzScX-0004zv-Q1 for qemu-devel@nongnu.org; Mon, 20 Feb 2012 07:45:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzScW-00069K-Ie for qemu-devel@nongnu.org; Mon, 20 Feb 2012 07:45:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzScW-00069E-Bp for qemu-devel@nongnu.org; Mon, 20 Feb 2012 07:45:32 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1KCjVTQ028988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Feb 2012 07:45:31 -0500 Message-ID: <4F424069.5050300@redhat.com> Date: Mon, 20 Feb 2012 13:45:29 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1329686886-6853-1-git-send-email-alevy@redhat.com> <1329686886-6853-5-git-send-email-alevy@redhat.com> <4F422A2E.3020106@redhat.com> <20120220123229.GE23926@garlic.redhat.com> In-Reply-To: <20120220123229.GE23926@garlic.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, elmarco@redhat.com Hi, >>> @@ -151,6 +171,7 @@ void qxl_render_update(PCIQXLDevice *qxl) >> >> dpy_update() call here. Calling that one isn't safe without grabbing >> the qemu lock. > > About dpy_update, discovered it the hard way. You mean I need the lock > for dpy_update or also before? Any qemu code should be considered thread-unsafe unless proven otherwise. On a quick scan I havn't noticed anything but the dpy_update() call. It makes sense to wrap the whole loop though, so you grab the lock only once. cheers, Gerd