Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

[Anthony Liguori <anthony@codemonkey.ws>]

On 02/20/2012 06:17 AM, Kevin Wolf wrote:
> Am 20.02.2012 00:44, schrieb Anthony Liguori:
>> I'm not attempting to make a pretty desktop virtualization UI.  Maybe we'll go
>> there eventually but that's not what this series is about.
>>
>> This is just attempting to use a richer toolkit such that we can enable basic
>> accessibility support.  As a consequence, the UI is much more usable even for a
>> user without accessibility requirements so it's a win-win.
>
> It's not quite obvious what the build dependencies are. In my case I had
> to install vte-devel. Especially if we're going to make it the default,
> I think configure should print a helpful warning. (In fact, SDL has the
> same problem and I have answered too many questions of users that
> wondered why no window appeared, not understanding that they built only
> VNC).

Ok, I'll try to do something here.

> I think the series is a good start, just some random thoughts and things
> that I noticed:
>
> * git complains about some trailing whitespace

Ack.

> * Half of the menu entries appears to be translated by the libraries
>    used. Give me something that is all German or something that is all
>    English. Mixed languages looks unprofessional.

This is because of the use of stock items.  I can overload the labels and force 
english menu names.  I can also add some basic internationalization and make 
greater use of stock item names.

I would actually prefer the later approach although practically speaking, the 
monitor would remain in English.  Would this seem awkward?

What's preferable for non-native English speakers?

> * Ctrl-Alt-= as shortcut for Zoom In isn't easy to remember and only
>    makes some sense on a US keyboard layout.

There doesn't appear to be a stock accelerator for Zoom in GTK.  Firefox 
advertises Ctrl-+ as the zoom in accelerator but apparently accepts Ctrl-+ or 
Ctrl-=.

I'd be happy with just doing Ctrl-Alt-+.  It's a little more awkward to type but 
that seems to be the standard.

> * The monitor display size always has the same size as the VGA tab now.
>    That can be quite small in text mode and you can't resize any more.

This should be fixable.  It will just take a little logic.

> * The window has a button for maximising, but it doesn't really do
>    anything.

This is your Window Manager.  We call gtk_window_set_resizable(False) and that 
should cause the maximize button to disappear.  Indeed, if you look at the 
screenshots I posted, there isn't a maximize button.

> * Ctrl-PgDn/PgUp does change the tab as I expected on VGA, it's ignored
>    by the monitor and the serial0 tabs.

This is something that probably needs some work.  Right now we propagate all key 
presses which is what allows the accelerators to work.  What we probably should 
do is check the key presses against only the accelerators we want to work and 
propagate those.

This is a bit tricky though.  The end effect would be that Ctrl-PgDn would stop 
working on the VGA tab.  I think this is expected behavior.

> parallel0 segfaults on any key
>    press.

Curious, I'll look into this.

>
> * When the tab bar is enables, the cursor up key in the VGA tab selects
>    the tab bar. It also is sent to the guest the first time, but when
>    the tab bar is selected, the guest doesn't get any input any more.
>    Makes it rather hard to use the shell history in the guest.

Yeah, this is the result of always propagating key presses.  I'll look into this 
a bit more.

Thanks for the feedback!

Regards,

Anthony Liguori

>
> Kevin
>