From: Meador Inge <meadori@codesourcery.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation
Date: Mon, 20 Feb 2012 08:11:12 -0600 [thread overview]
Message-ID: <4F425480.2090903@codesourcery.com> (raw)
In-Reply-To: <4F3FD2C1.4060409@suse.de>
On 02/18/2012 10:33 AM, Andreas Färber wrote:
> Am 17.02.2012 18:06, schrieb Andreas Färber:
>> Am 17.02.2012 18:03, schrieb Meador Inge:
>>> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f
>>> where 'watch_mem_write' was modified to fall-through to 'abort' on
>>> every input.
>>>
>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Actually I already reviewed such a fix by Max on Jan 29 (with breaks
> from the start), and it's in his PULL request now. So this is again a
> duplicate and shouldn't be applied.
>
> If you want to remind maintainers of a patch that's been on the list but
> has not yet been applied, the correct procedure is to add a Reviewed-by
> or Acked-by tag if you haven't already, or to reply with a "Ping?"
> otherwise.
Ah, I missed that. I will add a review tag to the other. Thanks for the heads
up.
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
prev parent reply other threads:[~2012-02-20 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 17:03 [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation Meador Inge
2012-02-17 17:06 ` Andreas Färber
2012-02-18 16:33 ` Andreas Färber
2012-02-20 14:11 ` Meador Inge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F425480.2090903@codesourcery.com \
--to=meadori@codesourcery.com \
--cc=afaerber@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).