From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1RzTxd-0003aY-FN
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:11:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1RzTxX-0005MG-FM
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:11:25 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:56987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1RzTxX-0005Lc-Aw
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:11:19 -0500
Message-ID: <4F425480.2090903@codesourcery.com>
Date: Mon, 20 Feb 2012 08:11:12 -0600
From: Meador Inge <meadori@codesourcery.com>
MIME-Version: 1.0
References: <1329498198-6009-1-git-send-email-meadori@codesourcery.com>
	<4F3E8903.6040807@suse.de> <4F3FD2C1.4060409@suse.de>
In-Reply-To: <4F3FD2C1.4060409@suse.de>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Max Filippov <jcmvbkbc@gmail.com>

On 02/18/2012 10:33 AM, Andreas Färber wrote:

> Am 17.02.2012 18:06, schrieb Andreas Färber:
>> Am 17.02.2012 18:03, schrieb Meador Inge:
>>> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f
>>> where 'watch_mem_write' was modified to fall-through to 'abort' on
>>> every input.
>>>
>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Actually I already reviewed such a fix by Max on Jan 29 (with breaks
> from the start), and it's in his PULL request now. So this is again a
> duplicate and shouldn't be applied.
> 
> If you want to remind maintainers of a patch that's been on the list but
> has not yet been applied, the correct procedure is to add a Reviewed-by
> or Acked-by tag if you haven't already, or to reply with a "Ping?"
> otherwise.

Ah, I missed that.  I will add a review tag to the other.  Thanks for the heads
up.

-- 
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software