From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzTxw-0004FN-HT for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:11:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzTxv-0005QP-Fx for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:11:44 -0500 Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:55964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzTxv-0005QH-8I for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:11:43 -0500 Received: by obbup16 with SMTP id up16so8184794obb.4 for ; Mon, 20 Feb 2012 06:11:42 -0800 (PST) Message-ID: <4F42549B.10609@codemonkey.ws> Date: Mon, 20 Feb 2012 08:11:39 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1329695104-15174-1-git-send-email-aliguori@us.ibm.com> <1329695104-15174-2-git-send-email-aliguori@us.ibm.com> <4F420FB8.9040008@redhat.com> <4F424E76.40305@codemonkey.ws> <4F4251CC.9040106@redhat.com> In-Reply-To: <4F4251CC.9040106@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Alex Graf On 02/20/2012 07:59 AM, Gerd Hoffmann wrote: > On 02/20/12 14:45, Anthony Liguori wrote: >> On 02/20/2012 03:17 AM, Gerd Hoffmann wrote: >>> On 02/20/12 00:44, Anthony Liguori wrote: >>>> We want to expose VCs using a VteTerminal widget. We need access to >>>> provide our >>>> own CharDriverState in order to do this. >>> >>> /me wonders why you touch vc's at all for this. Doesn't it make alot >>> more sense to just have a -chardev vte (which then opens a new tab in >>> the ui or something simliar)? >> >> Does it? That's essentially exactly what -chardev vc does today. vc >> currently works across all UIs (VNC, SDL, etc). > > They all use the qemu terminal emulation and render the chars on a > displaysurface. > >> It seems a bit odd to >> me to have to use a different argument for the GTK UI. > > Why is this odd? gtk *is* different, it takes the character stream and > sends them off to the terminal emulation widget. That allows to do > stuff vc can't handle by design, for example placing vte in a new window > instead of a tab so you can watch vga and serial console side-by-side. This would require touching a fair bit of code that handles things like defaults. I'm not sure that having the distinction makes anything easier to implement. One thing I was contemplating but ultimately didn't do was QOM-ification of the GTK front end. I couldn't rationalize why you would need to set settings but now I think maybe it would be more useful. So I'll take a pass in the next series at QOM-ification. I think I'll stick with 'vc' but this would effectively be only for legacy syntax. Regards, Anthony Liguori > > cheers, > Gerd > >