From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1RzTyw-0005Cq-2L
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:12:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1RzTyp-0005Wp-Dx
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:12:46 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:57118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1RzTyp-0005Wl-9e
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 09:12:39 -0500
Message-ID: <4F4254D4.1040309@codesourcery.com>
Date: Mon, 20 Feb 2012 08:12:36 -0600
From: Meador Inge <meadori@codesourcery.com>
MIME-Version: 1.0
References: <1329564636-29883-1-git-send-email-jcmvbkbc@gmail.com>
	<1329585103-31371-1-git-send-email-jcmvbkbc@gmail.com>
	<1329585103-31371-7-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1329585103-31371-7-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the
	watch_mem_write
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de

On 02/18/2012 11:11 AM, Max Filippov wrote:
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>

Reviewed-by: Meador Inge <meadori@codesourcery.com>

> ---
>  exec.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index b81677a..f105b43 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3289,9 +3289,15 @@ static void watch_mem_write(void *opaque, target_phys_addr_t addr,
>  {
>      check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE);
>      switch (size) {
> -    case 1: stb_phys(addr, val);
> -    case 2: stw_phys(addr, val);
> -    case 4: stl_phys(addr, val);
> +    case 1:
> +        stb_phys(addr, val);
> +        break;
> +    case 2:
> +        stw_phys(addr, val);
> +        break;
> +    case 4:
> +        stl_phys(addr, val);
> +        break;
>      default: abort();
>      }
>  }


-- 
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software