From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RzUsg-0006IR-BS
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 10:10:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RzUsW-0004a8-OW
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 10:10:22 -0500
Received: from mail-pz0-f45.google.com ([209.85.210.45]:33474)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RzUsW-0004Zz-Fp
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 10:10:12 -0500
Received: by dadp14 with SMTP id p14so7257625dad.4
	for <qemu-devel@nongnu.org>; Mon, 20 Feb 2012 07:10:11 -0800 (PST)
Message-ID: <4F426250.1000002@codemonkey.ws>
Date: Mon, 20 Feb 2012 09:10:08 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1329695104-15174-1-git-send-email-aliguori@us.ibm.com>	<1329695104-15174-2-git-send-email-aliguori@us.ibm.com>	<4F420FB8.9040008@redhat.com>	<4F424E76.40305@codemonkey.ws>
	<4F4251CC.9040106@redhat.com>	<4F42549B.10609@codemonkey.ws>
	<4F42585D.6080400@redhat.com>
In-Reply-To: <4F42585D.6080400@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by
 UI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Alex Graf <agraf@suse.de>

On 02/20/2012 08:27 AM, Gerd Hoffmann wrote:
>    Hi,
>
>> This would require touching a fair bit of code that handles things like
>> defaults.  I'm not sure that having the distinction makes anything
>> easier to implement.
>
> /me suggests to simply have no default terminals with qemu -gtk.
>
>> One thing I was contemplating but ultimately didn't do was QOM-ification
>> of the GTK front end.  I couldn't rationalize why you would need to set
>> settings but now I think maybe it would be more useful.
>
> With a vte chardev you have an object you can attach settings to, i.e.
> -chardev vte,mode={tab,window}.

Right, but you could do the same with QOM, it would look like:

GtkDisplay is-a UserInterface (maybe?)
   has-a GtkVirtualConsole "vc0"
   has-a GtkVirtualConsole "vc1"
   ...

GtkVirtualConsole could have a "mode" property.


So from a UI perspective, you would do something like:

-gtk -set /ui/vc0.mode=tab

I think it makes more sense overall as a sub-property of the main ui object 
verses a property of a character device (which is only tangentially related to 
the UI itself).

Regards,

Anthony Liguori

>
> cheers,
>    Gerd
>
>