From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RzZO0-0007Wx-P9
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 14:59:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RzZNz-0005hF-Mv
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 14:59:00 -0500
Received: from e32.co.us.ibm.com ([32.97.110.150]:50644)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RzZNz-0005h7-CX
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 14:58:59 -0500
Received: from /spool/local
	by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Mon, 20 Feb 2012 12:58:57 -0700
Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id B04F7C90067
	for <qemu-devel@nongnu.org>; Mon, 20 Feb 2012 14:58:54 -0500 (EST)
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q1KJwgMN2924644
	for <qemu-devel@nongnu.org>; Mon, 20 Feb 2012 14:58:43 -0500
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q1KJwgOV012008
	for <qemu-devel@nongnu.org>; Mon, 20 Feb 2012 17:58:42 -0200
Message-ID: <4F42A5F2.7060606@linux.vnet.ibm.com>
Date: Mon, 20 Feb 2012 14:58:42 -0500
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1323870202-25742-1-git-send-email-stefanb@linux.vnet.ibm.com>
	<1323870202-25742-3-git-send-email-stefanb@linux.vnet.ibm.com>
	<20120220085150.GB10364@redhat.com>
	<4F426B39.4020703@linux.vnet.ibm.com>
	<20120220193728.GB18308@redhat.com>
In-Reply-To: <20120220193728.GB18308@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware
 interface (TPM TIS) to Qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, andreas.niederl@iaik.tugraz.at

On 02/20/2012 02:37 PM, Michael S. Tsirkin wrote:
> On Mon, Feb 20, 2012 at 10:48:09AM -0500, Stefan Berger wrote:
>> On 02/20/2012 03:51 AM, Michael S. Tsirkin wrote:
>>> On Wed, Dec 14, 2011 at 08:43:17AM -0500, Stefan Berger wrote:
>>>
>> Yes, but that's ok. We are only registering the MMIO region [fed4
>> 0000, fed4 5000[, so anything larger than 4 cannot actually come
>> from this function.
> I see 12 matches 0x1000 where region is created.
> I think there should be a macro like TPM_TIS_LOCALITY_SHIFT
> and then you can register region of size
>   NUM_LOCALITIES<<  TPM_TIS_LOCALITY_SHIFT.
>
>

Done.

    Stefan