From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzanL-0001W9-PI for qemu-devel@nongnu.org; Mon, 20 Feb 2012 16:29:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzanK-0007Ph-L3 for qemu-devel@nongnu.org; Mon, 20 Feb 2012 16:29:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzanK-0007PU-EP for qemu-devel@nongnu.org; Mon, 20 Feb 2012 16:29:14 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1KLTCKa017095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Feb 2012 16:29:13 -0500 Message-ID: <4F42BB27.6070504@redhat.com> Date: Mon, 20 Feb 2012 14:29:11 -0700 From: Eric Blake MIME-Version: 1.0 References: <1329686886-6853-1-git-send-email-alevy@redhat.com> <1329686886-6853-6-git-send-email-alevy@redhat.com> <4F422F5C.9060202@redhat.com> In-Reply-To: <4F422F5C.9060202@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig8AFD5E0DC7FB92609BD4854A" Subject: Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Alon Levy , qemu-devel@nongnu.org, elmarco@redhat.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8AFD5E0DC7FB92609BD4854A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/20/2012 04:32 AM, Gerd Hoffmann wrote: > Hmm, that is pretty lame. There are users like autotest which expect > the screen dump being there when the monitor command is finished, that > change will break them. Libvirt is another such user. >=20 > Unfortunaly there is no easy way out. I think the options are: >=20 > (1) Keep existing behavior. That means the screenshot might show old > screen content. Not very nice too. Would work sort-of ok for > autotest though as autotest does screenshots every second and thus= > the screen content wouldn't be older than a second. >=20 > (2) Async monitor command. Keeps interface and works nicely. A bunch= > of QAPI bits tickled into master meanwhile, so we could look at > this again. Luiz? What is the status here? >=20 > (3) Something like this patch + additionally introduce a > "your-screenshot-is-finished-now" qmp event. Will break existing > users too. But at least they can be adapted without requiring > some external, nonportable service like inotify ... Libvirt would want 3) - any command that becomes async also needs an event to tell us when the command is completed, so that libvirt can maintain the synchronous interface to the user (and/or expose a new flag to allow the user to also benefit from the asynchronous command). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig8AFD5E0DC7FB92609BD4854A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPQrsnAAoJEKeha0olJ0Nq/TMH/1fou6bTtKqq63+w1GDC6y9v +EVladX/ira/L9PLZR0u/Sxd5DaCovJo/+D3KKl148cUK51uX5ufLqChzfdyk4We 7s6q87ul2jEg+nvcQ4p3Vvz9SScO2+sAZeUW84+csevwwH/2CJm0+6G5ly40qLWJ WofXpP0AIERu2QNHMfduy5RjXsuRzDnohOT7yXIs4HMCmJ77DjILqiwALIbae1DI 1ShnNTFuNm4mQpnqfQjmiWqi+Dqy/IHUyF6NNQC59pTLA/dgGhFLZloNvl7IQQjJ yw59y0BLn8JBmUCWgAvgndQ2A43rRlUIs3/YLfAem4ArGth8QQamGw/zcVajQYc= =jocq -----END PGP SIGNATURE----- --------------enig8AFD5E0DC7FB92609BD4854A--