From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Rzkc0-0005Te-SM
	for qemu-devel@nongnu.org; Tue, 21 Feb 2012 02:58:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Rzkbv-0007yL-DM
	for qemu-devel@nongnu.org; Tue, 21 Feb 2012 02:58:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Rzkbv-0007yC-2r
	for qemu-devel@nongnu.org; Tue, 21 Feb 2012 02:58:07 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1L7w58d029183
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 21 Feb 2012 02:58:05 -0500
Message-ID: <4F434E82.2030401@redhat.com>
Date: Tue, 21 Feb 2012 08:57:54 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1329686886-6853-1-git-send-email-alevy@redhat.com>
	<1329686886-6853-8-git-send-email-alevy@redhat.com>
	<4F423155.1010706@redhat.com>
	<20120220123823.GG23926@garlic.redhat.com>
	<4F42481B.3070605@redhat.com>
	<20120220173639.GJ23926@garlic.redhat.com>
In-Reply-To: <20120220173639.GJ23926@garlic.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 7/7] qxl: add allocator
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, elmarco@redhat.com

  Hi,

> TBH I'm having problems without doing it with my own Allocator. In
> particular calling ppm_save from spice_server thread seems to be a
> problem.

Grabbed the qemu mutex?

>> BTW: qxl insisting on a shared displaysurface isn't very clean too, it
>> better should be able to fallback to just copying/converting for the
>> non-shared case.
> 
> I'll try to get that working, although it seems to require having some
> timer/bh to do the ppm_save.

bh should do, that is one of the things they are supposed to handle.

cheers,
  Gerd