From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52331)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RzlC6-0003eT-I1
	for qemu-devel@nongnu.org; Tue, 21 Feb 2012 03:35:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RzlC0-0007R5-VF
	for qemu-devel@nongnu.org; Tue, 21 Feb 2012 03:35:30 -0500
Received: from mail-ee0-f45.google.com ([74.125.83.45]:38011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RzlC0-0007R0-P3
	for qemu-devel@nongnu.org; Tue, 21 Feb 2012 03:35:24 -0500
Received: by eekd17 with SMTP id d17so2766481eek.4
	for <qemu-devel@nongnu.org>; Tue, 21 Feb 2012 00:35:23 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F435747.2020304@redhat.com>
Date: Tue, 21 Feb 2012 09:35:19 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1329706897-30476-1-git-send-email-david@gibson.dropbear.id.au>
	<8A3EA298-2301-454F-81AE-301E1D898F50@suse.de>
In-Reply-To: <8A3EA298-2301-454F-81AE-301E1D898F50@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On 02/20/2012 11:50 AM, Alexander Graf wrote:
>> >     DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque);
>> > 
>> > -    trace_dma_bdrv_io(dbs, bs, sector_num, to_dev);
>> > +    trace_dma_bdrv_io(dbs, bs, sector_num, dir);
> Was the trace wrong before or is it now? I don't see its definition changed anywhere.

Not sure what you mean. :)

Paolo