From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzlfS-00080s-3D for qemu-devel@nongnu.org; Tue, 21 Feb 2012 04:05:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzlfL-0004bo-KQ for qemu-devel@nongnu.org; Tue, 21 Feb 2012 04:05:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzlfL-0004bV-AK for qemu-devel@nongnu.org; Tue, 21 Feb 2012 04:05:43 -0500 Message-ID: <4F435F2D.3010007@redhat.com> Date: Tue, 21 Feb 2012 10:09:01 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1329706897-30476-1-git-send-email-david@gibson.dropbear.id.au> <8A3EA298-2301-454F-81AE-301E1D898F50@suse.de> <4F435747.2020304@redhat.com> In-Reply-To: <4F435747.2020304@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Alexander Graf , David Gibson Am 21.02.2012 09:35, schrieb Paolo Bonzini: > On 02/20/2012 11:50 AM, Alexander Graf wrote: >>>> DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); >>>> >>>> - trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); >>>> + trace_dma_bdrv_io(dbs, bs, sector_num, dir); >> Was the trace wrong before or is it now? I don't see its definition changed anywhere. > > Not sure what you mean. :) trace-events: dma_bdrv_io(void *dbs, void *bs, int64_t sector_num, bool to_dev) "dbs=%p bs=%p sector_num=%" PRId64 " to_dev=%d" to_dev is declared bool here, and it should also be renamed to dir (the unfortunate thing about DMADirection is that it swaps 0 and 1 compared to bool to_dev... We need to check carefully that all occurrences have been caught.) Kevin