From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rzsbj-0003MX-3h for qemu-devel@nongnu.org; Tue, 21 Feb 2012 11:30:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rzsbe-0004Kf-QI for qemu-devel@nongnu.org; Tue, 21 Feb 2012 11:30:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rzsbe-0004KZ-EN for qemu-devel@nongnu.org; Tue, 21 Feb 2012 11:30:22 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1LGULVD031045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Feb 2012 11:30:21 -0500 Message-ID: <4F43C696.1010309@redhat.com> Date: Tue, 21 Feb 2012 09:30:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1329301701-30395-1-git-send-email-kraxel@redhat.com> <1329301701-30395-13-git-send-email-kraxel@redhat.com> <20120217153351.6416e5c5@doriath.home> <4F436B43.400@redhat.com> In-Reply-To: <4F436B43.400@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF42DB14184160164EFD16CD6" Subject: Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: libvirt-list@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF42DB14184160164EFD16CD6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/21/2012 03:00 AM, Gerd Hoffmann wrote: > [ added libvirt to Cc:, leaving full context. > this is about qmp events when the guest enters/leaves s3 ]. >=20 >>> @@ -1436,12 +1437,26 @@ void qemu_register_suspend_notifier(Notifier = *notifier) >>> =20 >>> void qemu_system_wakeup_request(WakeupReason reason) >>> { >>> + static const char *names[] =3D { >>> + [QEMU_WAKEUP_REASON_OTHER] =3D "other", >>> + [QEMU_WAKEUP_REASON_RTC] =3D "rtc", >>> + [QEMU_WAKEUP_REASON_PMTIMER] =3D "pmtimer", >> >> Is the reason really important for mngt? Can we just leave it out? >=20 > I assumed the wakeup reason could be useful, but dunno. > Zapping the code is no problem of course. >=20 > Lets ask mgmt aka libvirt folks ;) If you present the reason, libvirt will pass it on to the management app. But I don't see any reason why libvirt itself would care about the reason, so it won't hurt libvirt if you drop a reason field. I don't know whether higher-level management apps, like oVirt, would care or not.= Isn't this something where it is easier to omit first and add later once we have a use case, than to add up front only to find that no one cares? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF42DB14184160164EFD16CD6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPQ8aXAAoJEKeha0olJ0Nqj6sH/3jXbssuDtoUUcffaE5+9lCb zxDEfXeqgNuFlmW3w5D/z+Y01gsiAATquEUYVAs/iy9FUTwlGpzscNUlMHdvRBhi X9e4HQWueDabs5TJcGtmS+j2rZEYw3x/LQjXQqxyEeFHJh1SrQDdVIXCzr0P7U5G RuKKp3XxS+PgnrlOUsxsBZ8O6WB1YVukNdWBpKQ0wy1rI/W82/C+sNVNiCCR38xQ 1qAPXsSWHgwQ/ctzKxW6amfQY5njoZdf0xircyTIpzC292R7FD6Moq/1BTWhHS0y cJz7J2CvuuG/O9x+c5WT9P7ThlPoAsWBeGFeiJ7cyNSwS4yE1I7rXc+mV4qZkyA= =PUi5 -----END PGP SIGNATURE----- --------------enigF42DB14184160164EFD16CD6--