From: "Andreas Färber" <afaerber@suse.de>
To: 陳韋任 <chenwj@iis.sinica.edu.tw>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8
Date: Wed, 22 Feb 2012 10:18:49 +0100 [thread overview]
Message-ID: <4F44B2F9.1000204@suse.de> (raw)
In-Reply-To: <ji25cd$17a$1@dough.gmane.org>
Am 22.02.2012 08:27, schrieb Paolo Bonzini:
> On 02/22/2012 03:07 AM, 陳韋任 wrote:
>>
>> -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
>> +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF)
>
> This is not declaring the dependency, it is declaring a target.
>
> The rule should be like
>
> qemu-bridge-helper.o: config-host.h
...which Peter has already done:
http://patchwork.ozlabs.org/patch/142306/
Please coordinate with him.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-22 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 2:07 [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 陳韋任
2012-02-22 7:27 ` Paolo Bonzini
2012-02-22 9:18 ` Andreas Färber [this message]
2012-02-23 3:45 ` 陳韋任
2012-02-23 3:43 ` 陳韋任
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F44B2F9.1000204@suse.de \
--to=afaerber@suse.de \
--cc=chenwj@iis.sinica.edu.tw \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).