From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0A5U-0003ld-N7
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 06:10:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0A5P-0005jx-2j
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 06:10:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45052)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0A5O-0005jl-Kx
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 06:10:14 -0500
Message-ID: <4F44CD10.2040103@redhat.com>
Date: Wed, 22 Feb 2012 12:10:08 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1329860377-6284-1-git-send-email-alevy@redhat.com>
	<1329860377-6284-5-git-send-email-alevy@redhat.com>
In-Reply-To: <1329860377-6284-5-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single
	ppm_save
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: elmarco@redhat.com, yhalperi@redhat.com, qemu-devel@nongnu.org, spice-devel@freedesktop.org

On 02/21/12 22:39, Alon Levy wrote:
> Using vga->screen_dump results in a number of calls to ppm_save,
> instead of a single one.

Can you investigate why?

> Lacking time to test all the possible users of
> vga->screen_dump, avoid the redundant calls by doing the vga_hw_update+
> ppm_save in qxl_hw_screen_dump.

I'd prefer to fix the root cause instead of adding workarounds.

cheers,
  Gerd