From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0AHu-0008Mc-N0
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 06:23:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0AHo-0007g2-Hm
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 06:23:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17416)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0AHo-0007fo-BH
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 06:23:04 -0500
Message-ID: <4F44D014.4050102@redhat.com>
Date: Wed, 22 Feb 2012 12:23:00 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1329860377-6284-1-git-send-email-alevy@redhat.com>
	<1329860377-6284-8-git-send-email-alevy@redhat.com>
In-Reply-To: <1329860377-6284-8-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 7/9] qxl: introduce QXLCookie
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: elmarco@redhat.com, yhalperi@redhat.com, qemu-devel@nongnu.org, spice-devel@freedesktop.org

On 02/21/12 22:39, Alon Levy wrote:
> Will be used in the next patch.

Looks good, and is more readable without all the #ifdefs.

>  static void qxl_spice_flush_surfaces_async(PCIQXLDevice *qxl)
>  {
> -    spice_qxl_flush_surfaces_async(&qxl->ssd.qxl, 0);
> + spice_qxl_flush_surfaces_async(&qxl->ssd.qxl,
> +        (uint64_t)qxl_cookie_new(QXL_COOKIE_TYPE_IO,
> +                                 QXL_IO_FLUSH_SURFACES_ASYNC));

minor whitespace issue here ;)

cheers,
  Gerd