From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0C6k-0003qk-Ql for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:19:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0C6e-00041N-N9 for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:19:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0C6e-00041I-GS for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:19:40 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1MDJcjk024801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Feb 2012 08:19:38 -0500 Message-ID: <4F44EC3B.9090902@redhat.com> Date: Wed, 22 Feb 2012 14:23:07 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1329506504-29152-1-git-send-email-lcapitulino@redhat.com> <1329506504-29152-6-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1329506504-29152-6-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Am 17.02.2012 20:21, schrieb Luiz Capitulino: > It's emitted whenever the tray is moved by the guest or by HMP/QMP > commands. > > Signed-off-by: Luiz Capitulino > --- > QMP/qmp-events.txt | 18 ++++++++++++++++++ > block.c | 24 ++++++++++++++++++++++++ > monitor.c | 3 +++ > monitor.h | 1 + > 4 files changed, 46 insertions(+), 0 deletions(-) > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index 06cb404..9286af5 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -26,6 +26,24 @@ Example: > Note: If action is "stop", a STOP event will eventually follow the > BLOCK_IO_ERROR event. > > +DEVICE_TRAY_MOVED > +----------------- > + > +It's emitted whenever the tray of a removable device is moved by the guest > +or by HMP/QMP commands. > + > +Data: > + > +- "device": device name (json-string) For me, a device name is something related to qdev. 'device' is a misnomer consistently used in all QMP commands so far and we can't fix it any more, but at least the documentation should clarify what is meant (that's for a follow-up patch). Kevin