From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0Ci7-0007xc-Li
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:58:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0Chz-000346-9B
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:58:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0Chz-00033z-0E
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:58:15 -0500
Message-ID: <4F44F472.6000402@redhat.com>
Date: Wed, 22 Feb 2012 14:58:10 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1329860377-6284-1-git-send-email-alevy@redhat.com>
	<1329860377-6284-5-git-send-email-alevy@redhat.com>
	<4F44CD10.2040103@redhat.com>
	<20120222122616.GB607@garlic.redhat.com>
In-Reply-To: <20120222122616.GB607@garlic.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single
	ppm_save
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, spice-devel@freedesktop.org, yhalperi@redhat.com, elmarco@redhat.com

> And the only user of screen_dump_filename is:
> 
> static void vga_save_dpy_update(DisplayState *ds,
>                                 int x, int y, int w, int h)
> {
>     if (screen_dump_filename) {
>         ppm_save(screen_dump_filename, ds->surface);

upstream/master this here:

          screen_dump_filename = NULL;

>     }
> }

> This seems to work, only tested with -vga qxl and in vga mode:

The corner case where this fails is when console switching is needed,
i.e. switch to monitor console via ctrl-alt-2, then type the screenshot
command there ...