Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

[Gerd Hoffmann <kraxel@redhat.com>]

On 02/22/12 15:25, Alon Levy wrote:
> On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote:
>>> And the only user of screen_dump_filename is:
>>>
>>> static void vga_save_dpy_update(DisplayState *ds,
>>>                                 int x, int y, int w, int h)
>>> {
>>>     if (screen_dump_filename) {
>>>         ppm_save(screen_dump_filename, ds->surface);
>>
>> upstream/master this here:
>>
>>           screen_dump_filename = NULL;
>>
> 
> That's wrong, you'll get the screenshot after the first update, who's to
> say it is fully rendered?

vga code actually does a single, fullscreen update after
vga_invalidate_display(), so it should work fine.

>> The corner case where this fails is when console switching is needed,
>> i.e. switch to monitor console via ctrl-alt-2, then type the screenshot
>> command there ...
> 
> Are you talking about sdl console or linux guest console? ctrl-alt-2 or
> ctrl-alt-F2? I can try both.

ctrl-alt-2 sdl console.

cheers,
  Gerd