From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0DKP-0007pq-Dd for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:38:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0DKJ-0002u3-CU for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:37:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0DKI-0002tu-Vv for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:37:51 -0500 Message-ID: <4F44FDBA.50402@redhat.com> Date: Wed, 22 Feb 2012 15:37:46 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1329860377-6284-1-git-send-email-alevy@redhat.com> <1329860377-6284-5-git-send-email-alevy@redhat.com> <4F44CD10.2040103@redhat.com> <20120222122616.GB607@garlic.redhat.com> <4F44F472.6000402@redhat.com> <20120222142517.GB8461@garlic> In-Reply-To: <20120222142517.GB8461@garlic> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, spice-devel@freedesktop.org, yhalperi@redhat.com, elmarco@redhat.com On 02/22/12 15:25, Alon Levy wrote: > On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote: >>> And the only user of screen_dump_filename is: >>> >>> static void vga_save_dpy_update(DisplayState *ds, >>> int x, int y, int w, int h) >>> { >>> if (screen_dump_filename) { >>> ppm_save(screen_dump_filename, ds->surface); >> >> upstream/master this here: >> >> screen_dump_filename = NULL; >> > > That's wrong, you'll get the screenshot after the first update, who's to > say it is fully rendered? vga code actually does a single, fullscreen update after vga_invalidate_display(), so it should work fine. >> The corner case where this fails is when console switching is needed, >> i.e. switch to monitor console via ctrl-alt-2, then type the screenshot >> command there ... > > Are you talking about sdl console or linux guest console? ctrl-alt-2 or > ctrl-alt-F2? I can try both. ctrl-alt-2 sdl console. cheers, Gerd