From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0EGZ-0000wK-80 for qemu-devel@nongnu.org; Wed, 22 Feb 2012 10:38:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0EGU-0005ze-Bu for qemu-devel@nongnu.org; Wed, 22 Feb 2012 10:38:03 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33543 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0EGT-0005zV-Ts for qemu-devel@nongnu.org; Wed, 22 Feb 2012 10:37:58 -0500 Message-ID: <4F450BD3.3010909@suse.de> Date: Wed, 22 Feb 2012 16:37:55 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329905754-11873-1-git-send-email-i.mitsyanko@samsung.com> <87d397ufsh.fsf@elfo.elfo> In-Reply-To: <87d397ufsh.fsf@elfo.elfo> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/5] VMState cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: Peter Maydell , Igor Mitsyanko , e.voevodin@samsung.com, qemu-devel@nongnu.org, Alexander Graf , kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com Am 22.02.2012 15:02, schrieb Juan Quintela: > Peter Maydell wrote: >> On 22 February 2012 10:15, Igor Mitsyanko wr= ote: >>> This patchset cleans up and optimizes vmstate implementation. >>> >>> Patch 1 is a trivial bug fixing. >>> Patches 2 and 3 replaces target_phys_addr_t in pxa implementation >>> to uint32_t. >>> Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit depende= ncy >>> on NEED_CPU_H is droped, I failed to understand why it was presented = at all. >> >> So if we apply patches 1-3 (which all look plausible) then the only >> remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as >> I can see. >> >> This leaves me wondering if we shouldn't just put it actually in >> target-i386/machine.c as a convenience macro for that specific CPU >> to avoid having to have more #ifdef TARGET_X86_64s. (I note that >> the machine.c code is already pretty inconsistent, eg lstar and >> cstar are defined as target_ulong and saved with VMSTATE_UINT64.) >=20 > With my cpu-vmstate patches, all 32/64 bit cpus use it. NB: Your cpu-vmstate patches were not applied so far and they appear to conflict with the plans we've made for redesigning cp15 on ARM: We want to convert today's static fields to some list and were hoping to have a mapping function for backwards compatibility. That works easiest in imperative code. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg