From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0GIM-0008Bc-If for qemu-devel@nongnu.org; Wed, 22 Feb 2012 12:48:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0GIG-0006XC-VJ for qemu-devel@nongnu.org; Wed, 22 Feb 2012 12:48:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0GIG-0006Wy-Oa for qemu-devel@nongnu.org; Wed, 22 Feb 2012 12:47:56 -0500 Message-ID: <4F452A38.2060204@redhat.com> Date: Wed, 22 Feb 2012 10:47:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <4F450170.5070806@codemonkey.ws> <4F4513FE.4070100@redhat.com> <4F45275E.4000304@codemonkey.ws> In-Reply-To: <4F45275E.4000304@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2D430A8C1527334071A6602A" Subject: Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Markus Armbruster , jcody@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2D430A8C1527334071A6602A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/22/2012 10:35 AM, Anthony Liguori wrote: >> [1] JSON schema definition: >> >> { 'type': 'SnapshotDev', >> 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } }= >> >> { 'command': 'blockdev-group-snapshot-sync', >> 'data': { 'dev': [ 'SnapshotDev' ] } } >=20 >=20 > This will end up looking like: >=20 > { "execute": "blockdev-group-snapshot-sync", > "arguments": { "dev": [{"device": "ide-hd0"....}] } } Does that mean we want it to look more like: { 'command': 'blockdev-group-snapshot-sync', 'data': { 'devlist': [ 'SnapshotDev' ] } } and used like: { "execute": "blockdev-group-snapshot-sync", "arguments": { "devlist": [{ "device": "ide-hd0" ...}, { "device": "ide-hd1" ...}] } } I don't quite care what syntax we use, as long as we settle on something soon, because I'm trying to code up libvirt to generate this new monitor command, and need to know what syntax it will use. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2D430A8C1527334071A6602A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPRSpJAAoJEKeha0olJ0Nqj5oIAKbwZm8z+kXAwjeU7l678GlR P+HKgKpT7VriEO7snAIB4IKhw8TAUdTgUuywLQPdV+OR/us0IvecLtIKTiZxkT3n Ipa7O5xPkWTCEnp267y0J4OEZ0eP0x2Xgl9NT9NpkKE2BPzjmhl/l2VWBRALFhbc 5BtEbnYp7fwUiKbDVTkjToUpSwAhD/63WyOlggv7pM7kJusan9PXDrZVPCtzgmB2 xzlQXahbu9G7AWbXIOLoV5Uc/Ke+dBAeLRWL6ODOnBDWAS0EArtaOv8ueFo0LSqs EccIfsMtPqsJPxR9Z39F95maVfimL4cQLjNac832hCXNBjYi6cbxj0g9md0o4dc= =hXPG -----END PGP SIGNATURE----- --------------enig2D430A8C1527334071A6602A--