From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1S0Gzn-0002py-D2
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:32:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1S0Gzm-0006ar-Bs
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:32:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45514)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1S0Gzm-0006an-2u
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:32:54 -0500
Message-ID: <4F4534D1.6030601@redhat.com>
Date: Wed, 22 Feb 2012 13:32:49 -0500
From: Jeff Cody <jcody@redhat.com>
MIME-Version: 1.0
References: <cover.1329758006.git.jcody@redhat.com>
	<b1cb4492a8688f295a7c8eaddd06a53dd3cae664.1329758006.git.jcody@redhat.com>
	<4F450170.5070806@codemonkey.ws> <4F4513FE.4070100@redhat.com>
	<4F45275E.4000304@codemonkey.ws> <4F452A38.2060204@redhat.com>
	<4F452C43.1030907@codemonkey.ws>
In-Reply-To: <4F452C43.1030907@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have
 array inputs
Reply-To: jcody@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 02/22/2012 12:56 PM, Anthony Liguori wrote:
> On 02/22/2012 11:47 AM, Eric Blake wrote:
>> On 02/22/2012 10:35 AM, Anthony Liguori wrote:
>>
>>>> [1] JSON schema definition:
>>>>
>>>> { 'type': 'SnapshotDev',
>>>> 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } }
>>>>
>>>> { 'command': 'blockdev-group-snapshot-sync',
>>>> 'data': { 'dev': [ 'SnapshotDev' ] } }
>>>
>>>
>>> This will end up looking like:
>>>
>>> { "execute": "blockdev-group-snapshot-sync",
>>> "arguments": { "dev": [{"device": "ide-hd0"....}] } }
>>
>> Does that mean we want it to look more like:
>>
>> { 'command': 'blockdev-group-snapshot-sync',
>> 'data': { 'devlist': [ 'SnapshotDev' ] } }
>>
>> and used like:
>>
>> { "execute": "blockdev-group-snapshot-sync",
>> "arguments": { "devlist": [{ "device": "ide-hd0" ...},
>> { "device": "ide-hd1" ...}] } }
>
>
> Yes, devlist is a better variable name.
>

I will change it to devlist, for the v2 patch submission.

>>
>> I don't quite care what syntax we use, as long as we settle on something
>> soon, because I'm trying to code up libvirt to generate this new monitor
>> command, and need to know what syntax it will use.
>
>
> Just FYI, I've looked at the QAPI bits so far. I would suggest getting
> an Ack from Kevin at least that this API is reasonable inline with what
> we're looking for here before you start doing libvirt support.
>
> Personally, I loathe the idea of extending an already broken
> interface... I would rather we fix the original interface first before
> tacking on additional features.
>
> Regards,
>
> Anthony Liguori
>
>