From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S0HD6-0004np-MS
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:46:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S0HD5-0000NZ-Gp
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:46:40 -0500
Message-ID: <4F453808.7020401@codemonkey.ws>
Date: Wed, 22 Feb 2012 12:46:32 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1329835480-22192-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1329835480-22192-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile: Add dependency to fix
 linux-user-only build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Corey Bryant <coreyb@linux.vnet.ibm.com>, qemu-devel@nongnu.org, =?UTF-8?B?6Zmz6Z+L5Lu7?= <chenwj@iis.sinica.edu.tw>

On 02/21/2012 08:44 AM, Peter Maydell wrote:
> Make qemu-bridge-helper explicitly depend on $(GENERATED_HEADERS)
> so that it doesn't fail to build when we configured for linux-user
> targets only. (Build breakage introduced in commit 7b93fad.)
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> I suspect we could handle generated headers better in our makefile
> than having to scatter $(GENERATED_HEADERS) dependencies into almost
> everything (eg "%.o: $(GENERATED_HEADERS)" ??) but this is the minimal
> fix for the build breakage which we should apply for now I think.
>
>   Makefile |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e66e885..c67493e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,6 +159,7 @@ qemu-nbd$(EXESUF): qemu-nbd.o $(tools-obj-y) $(block-obj-y)
>   qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y) $(block-obj-y)
>
>   qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o
> +qemu-bridge-helper.o: $(GENERATED_HEADERS)
>
>   fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o oslib-posix.o $(trace-obj-y)
>   fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap