From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0HJZ-0008M8-R0 for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:53:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0HJY-0001Q6-Db for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:53:21 -0500 Message-ID: <4F45399B.4060208@codemonkey.ws> Date: Wed, 22 Feb 2012 12:53:15 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1329695347-9289-1-git-send-email-afaerber@suse.de> In-Reply-To: <1329695347-9289-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] qom: Fix object_initialize_with_type() assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, qemu-devel@nongnu.org On 02/19/2012 05:49 PM, Andreas Färber wrote: > Assert the object is at least sizeof(Object), not sizeof(ObjectClass). > > Signed-off-by: Andreas Färber Applied. Thanks. Regards, Anthony Liguori > --- > qom/object.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index b1ead15..dbfd6a4 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -262,7 +262,7 @@ void object_initialize_with_type(void *data, TypeImpl *type) > Object *obj = data; > > g_assert(type != NULL); > - g_assert(type->instance_size>= sizeof(ObjectClass)); > + g_assert(type->instance_size>= sizeof(Object)); > > type_class_init(type); > g_assert(type->abstract == false);