From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0HKO-0000kJ-7E for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:54:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0HKJ-0001fT-9i for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:54:12 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:61904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0HKI-0001fD-Ui for qemu-devel@nongnu.org; Wed, 22 Feb 2012 13:54:07 -0500 Received: by dadp14 with SMTP id p14so388933dad.4 for ; Wed, 22 Feb 2012 10:54:06 -0800 (PST) Message-ID: <4F4539CA.2070600@codemonkey.ws> Date: Wed, 22 Feb 2012 12:54:02 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1329895136-20494-1-git-send-email-jordan.l.justen@intel.com> In-Reply-To: <1329895136-20494-1-git-send-email-jordan.l.justen@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 0/9] PC system flash support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: qemu-devel@nongnu.org On 02/22/2012 01:18 AM, Jordan Justen wrote: > Enable flash emulation in a PC system using pflash_cfi01. Applied all. I know it's taken a while to get these merged, but I'm very pleased with the final result. Thanks for sticking through it! Regards, Anthony Liguori > > v11: > * Convert pc-sysfw to qdev > - Add rom_only property > * Remove KVM flash support to remove the need for using > bdrv_read during machine initialization. KVM should > now continue to use the same 'rom' initialization > sequence that it uses today. > > v10: > * Rebase to HEAD > * "decouple vmstate from memory API" as in c5705a7 > * Break changes into smaller pieces > > v9: > * Add pc-1.1 > * pc-1.0 uses previous rom firmware init code path > > v8: > * Cleanup two chunks of debug code (printf messages) > * Fix comment in pc.h (pcflash.c => pc_sysfw.c) > > v7: > * Do not add system firmware to qemu roms > * If kvm is enabled, copy pflash drive contents into a > read-only ram region, since kvm cannot currently execute > code from a pflash device. > * Rename pcflash.c to pc_sysfw.c > > v6: > * Rebase for memory API > * pflash_cfi01: Set error in status register when a write to > erase is attempted in read-only mode. > * Add system firmware to qemu roms > > v5: > * Enable pflash read-only mode > * Enable -drive with if=pflash to define system firmware image > > v4: > * Rebase > > v3: > * Fix code style issues > * Add additional comments > > v2: > * Convert debug printf to DPRINTF > > Jordan Justen (9): > blockdev: allow read-only pflash devices > pflash_cfi01/02: support read-only pflash devices > vl: make find_default_machine externally visible > hw/pc: move rom init to pc_sysfw.c > hw/pc_sysfw: enable pc-sysfw as a qdev > hw/pc_sysfw: support system flash memory with pflash > hw/pc_piix: remove is_default for pc-0.15 > hw/pc_piix: add pc-1.1 > pc_piix/pc_sysfw: enable flash by default > > Makefile.target | 1 + > blockdev.c | 3 +- > default-configs/i386-softmmu.mak | 1 + > default-configs/x86_64-softmmu.mak | 1 + > hw/boards.h | 1 + > hw/pc.c | 56 +------- > hw/pc.h | 3 + > hw/pc_piix.c | 62 +++++++++- > hw/pc_sysfw.c | 254 ++++++++++++++++++++++++++++++++++++ > hw/pflash_cfi01.c | 44 +++++-- > hw/pflash_cfi02.c | 83 +++++++------ > vl.c | 2 +- > 12 files changed, 403 insertions(+), 108 deletions(-) > create mode 100644 hw/pc_sysfw.c > > >