From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1S0fZY-0007rV-3H
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 15:47:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1S0fZW-0004po-K9
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 15:47:28 -0500
Received: from e7.ny.us.ibm.com ([32.97.182.137]:38332)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1S0fZW-0004p3-HV
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 15:47:26 -0500
Received: from /spool/local
	by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Thu, 23 Feb 2012 15:47:23 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id F07D16E8057
	for <qemu-devel@nongnu.org>; Thu, 23 Feb 2012 15:47:19 -0500 (EST)
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q1NKlFWn284352
	for <qemu-devel@nongnu.org>; Thu, 23 Feb 2012 15:47:16 -0500
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id q1NKlA6w015430
	for <qemu-devel@nongnu.org>; Thu, 23 Feb 2012 13:47:10 -0700
Message-ID: <4F46A5CC.2060602@linux.vnet.ibm.com>
Date: Thu, 23 Feb 2012 15:47:08 -0500
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1323870202-25742-1-git-send-email-stefanb@linux.vnet.ibm.com>
	<1323870202-25742-3-git-send-email-stefanb@linux.vnet.ibm.com>
	<20120220085150.GB10364@redhat.com>
	<4F426B39.4020703@linux.vnet.ibm.com>
In-Reply-To: <4F426B39.4020703@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware
 interface (TPM TIS) to Qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, andreas.niederl@iaik.tugraz.at

On 02/20/2012 10:48 AM, Stefan Berger wrote:
> On 02/20/2012 03:51 AM, Michael S. Tsirkin wrote:
>
>
>>> +static const MemoryRegionOps tpm_tis_memory_ops = {
>>> +    .read = tpm_tis_mmio_read,
>>> +    .write = tpm_tis_mmio_write,
>>> +    .endianness = DEVICE_NATIVE_ENDIAN,
>> Are you sure? Most devices are BIG or LITTLE.
>>
>
> Right, it should be BIG endian. I'll fix it. Luckily there are only a 
> few 32bit accesses (and no 16bit access) also in 

Replace that with 'LITTLE endian'.

    Stefan