From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37682)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S0rGJ-00023W-A7
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 04:16:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S0rGD-00075x-H2
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 04:16:22 -0500
Received: from cantor2.suse.de ([195.135.220.15]:52412 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S0rGD-00073e-B0
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 04:16:17 -0500
Message-ID: <4F475547.1020102@suse.de>
Date: Fri, 24 Feb 2012 10:15:51 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330043806-31899-1-git-send-email-david@gibson.dropbear.id.au>
	<1330043806-31899-3-git-send-email-david@gibson.dropbear.id.au>
In-Reply-To: <1330043806-31899-3-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/3] Allow larger return values from
	get_image_size()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

Am 24.02.2012 01:36, schrieb David Gibson:
> Currently get_image_size(), used to find the size of files, returns an =
int.
> But for modern systems, int may be only 32-bit and we can have files
> larger than that.
>=20
> This patch, therefore, changes the return type of get_image_size() to o=
ff_t
> (the same as the return type from lseek() itself).  It also audits all =
the
> callers of get_image_size() to make sure they process the new unsigned
> return type correctly.

It's a size, so why off_t and not size_t?

Andreas

>=20
> This leaves load_image_targphys() with a limited return type, but one t=
hing
> at a time (that function has far more callers to be audited, so it will
> take longer to fix).
>=20
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg