From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0rPj-0006co-JP for qemu-devel@nongnu.org; Fri, 24 Feb 2012 04:26:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0rPZ-0000FQ-My for qemu-devel@nongnu.org; Fri, 24 Feb 2012 04:26:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0rPZ-0000FD-Dy for qemu-devel@nongnu.org; Fri, 24 Feb 2012 04:25:57 -0500 Message-ID: <4F475874.8050803@redhat.com> Date: Fri, 24 Feb 2012 10:29:24 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <20120210062608.13397.43361.stgit@dhcp-8-167.nay.redhat.com> <20120210062719.13397.9953.stgit@dhcp-8-167.nay.redhat.com> In-Reply-To: <20120210062719.13397.9953.stgit@dhcp-8-167.nay.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com Am 10.02.2012 07:27, schrieb Amos Kong: > IPv6 address contains colons, parse will be wrong. > > [2312::8274]:5200 > > Signed-off-by: Amos Kong > --- > net.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net.c b/net.c > index f63014c..9e1ef9e 100644 > --- a/net.c > +++ b/net.c > @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep) > const char *p, *p1; > int len; > p = *pp; > - p1 = strchr(p, sep); > + p1 = strrchr(p, sep); > if (!p1) > return -1; > len = p1 - p; And what if the port isn't specified? I think you would erroneously interpret the last part of the IP address as port. Kevin