From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0wnE-0005DU-2h for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:10:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0wmp-0000D9-84 for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:10:43 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45930 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0wmp-0000D3-0n for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:10:19 -0500 Message-ID: <4F47A859.5010807@suse.de> Date: Fri, 24 Feb 2012 16:10:17 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1330092792-22455-1-git-send-email-lcapitulino@redhat.com> <1330092792-22455-6-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1330092792-22455-6-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Am 24.02.2012 15:13, schrieb Luiz Capitulino: > The license text is the same as used in vl.c. Also note that it's > necessary to make machine_parse() public. >=20 > Signed-off-by: Luiz Capitulino > --- > Makefile.target | 3 +- > hw/boards.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > hw/boards.h | 1 + > vl.c | 65 ----------------------------------------- > 4 files changed, 89 insertions(+), 66 deletions(-) > create mode 100644 hw/boards.c In anticipation of a "board" class derived from "container" I would rather have the file name match the class name, i.e. board.c. Unfortunately boards.h is used in quite a lot of places already, but when we QOM'ify it we might want to move it to include/qemu so all users would need to be touched anyway. > diff --git a/Makefile.target b/Makefile.target > index d5eb70d..dc76eba 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -195,7 +195,8 @@ endif #CONFIG_BSD_USER > # System emulator target > ifdef CONFIG_SOFTMMU > =20 > -obj-y =3D arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o i= oport.o > +obj-y =3D arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o i= oport.o \ > + boards.o Please use obj-y +=3D ... instead of the line break. Otherwise looks okay. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg