From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0x7W-0007VC-El for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:31:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0x7N-0004a8-JW for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:31:42 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:53074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0x7N-0004a3-Dl for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:31:33 -0500 Received: by pbbro12 with SMTP id ro12so3276632pbb.4 for ; Fri, 24 Feb 2012 07:31:32 -0800 (PST) Message-ID: <4F47AD4C.9080305@codemonkey.ws> Date: Fri, 24 Feb 2012 09:31:24 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1329497164-20086-1-git-send-email-afaerber@suse.de> In-Reply-To: <1329497164-20086-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/4] target-i386: Helpers for CPUID version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: andre.przywara@amd.com, qemu-devel@nongnu.org On 02/17/2012 10:46 AM, Andreas Färber wrote: > Hello x86 gurus, > > This series came out of my qom-cpu work. The reasoning is that in a QOM world > we will need this logic twice, once as before and once for > -cpu family=x,model=y,stepping=z,model_id=foo. > > Note: The family=x value is not bounds-checked in cpu_x86_find_by_name()! > > I'd appreciate if someone could double-check the masks I added. I calculated > them based on "Intel® Processor Identification and the CPUID Instruction. > Application Note 485. January 2011". Applied. Thanks. Regards, Anthony Liguori > > Thanks, > Andreas > > Cc: Andre Przywara > > Andreas Färber (4): > target-i386: Introduce x86_cpuid_version_set_family() > target-i386: Introduce x86_cpuid_version_set_model() > target-i386: Introduce x86_cpuid_version_set_stepping() > target-i386: Introduce x86_cpuid_set_model_id() > > target-i386/cpuid.c | 64 +++++++++++++++++++++++++++++++++++---------------- > 1 files changed, 44 insertions(+), 20 deletions(-) >