From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexander Graf <agraf@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>,
qemu-devel@nongnu.org, Hannes Reinecke <hare@suse.de>,
Andreas Faerber <afaerber@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation
Date: Fri, 24 Feb 2012 10:13:31 -0600 [thread overview]
Message-ID: <4F47B72B.9040501@codemonkey.ws> (raw)
In-Reply-To: <5EAF9E40-85DA-496C-B423-5AD51A97C242@suse.de>
On 02/24/2012 10:05 AM, Alexander Graf wrote:
>
>>>
>>> So Alex asked whether I can merge this, which made me
>>> take a look. I don't know much about what this does
>>> so just general comments on all of the code.
>>
>> This should come through Paolo's new SCSI tree.
>>
>> And while I defended this before, I now think it really ought to be split after trying (and failing) to trim the bits below in Thunderbird.
>
> Split up in what pieces? The only natural split I could think of would be mfi.h and megasas.c.
That would certainly help.
> Splitting megasas.c inside of itself doesn't really make sense, as it's just a new device and useless when not complete.
That doesn't mean that splitting it isn't the right strategy. But I bet just
pulling out mfi.h would make it a lot more reasonable to handle.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2012-02-24 16:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 9:36 [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-02-21 18:54 ` Gerhard Wiesinger
2012-02-23 7:03 ` Gerhard Wiesinger
2012-02-23 7:14 ` Andreas Färber
2012-02-23 7:20 ` Gerhard Wiesinger
2012-02-23 7:12 ` Alexander Graf
2012-02-23 15:34 ` Michael S. Tsirkin
2012-02-24 15:58 ` Anthony Liguori
2012-02-24 16:05 ` Alexander Graf
2012-02-24 16:13 ` Anthony Liguori [this message]
2012-02-27 9:17 ` Hannes Reinecke
2012-02-27 10:31 ` Michael S. Tsirkin
2012-02-27 15:24 ` Hannes Reinecke
2012-03-02 7:20 ` Gerhard Wiesinger
2012-02-27 13:47 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47B72B.9040501@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=hare@suse.de \
--cc=lists@wiesinger.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).