From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S0xm5-0006IR-Rt
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:13:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S0xm4-0003Uj-Kk
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:13:37 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:51769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S0xm4-0003Ua-EO
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:13:36 -0500
Received: by pbbro12 with SMTP id ro12so3323283pbb.4
	for <qemu-devel@nongnu.org>; Fri, 24 Feb 2012 08:13:35 -0800 (PST)
Message-ID: <4F47B72B.9040501@codemonkey.ws>
Date: Fri, 24 Feb 2012 10:13:31 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1329817003-31125-1-git-send-email-hare@suse.de>
	<20120223153419.GA20732@redhat.com>
	<4F47B393.7070606@codemonkey.ws>
	<5EAF9E40-85DA-496C-B423-5AD51A97C242@suse.de>
In-Reply-To: <5EAF9E40-85DA-496C-B423-5AD51A97C242@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA
	emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, qemu-devel@nongnu.org, Hannes Reinecke <hare@suse.de>, Andreas Faerber <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

On 02/24/2012 10:05 AM, Alexander Graf wrote:
>
>>>
>>> So Alex asked whether I can merge this, which made me
>>> take a look. I don't know much about what this does
>>> so just general comments on all of the code.
>>
>> This should come through Paolo's new SCSI tree.
>>
>> And while I defended this before, I now think it really ought to be split after trying (and failing) to trim the bits below in Thunderbird.
>
> Split up in what pieces? The only natural split I could think of would be mfi.h and megasas.c.

That would certainly help.

> Splitting megasas.c inside of itself doesn't really make sense, as it's just a new device and useless when not complete.

That doesn't mean that splitting it isn't the right strategy.  But I bet just 
pulling out mfi.h would make it a lot more reasonable to handle.

Regards,

Anthony Liguori