From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0xoj-0007K5-QJ for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:16:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0xod-00043s-Uy for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:16:21 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:47188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0xod-00043h-R0 for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:16:15 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 24 Feb 2012 11:16:14 -0500 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 6967238C805E for ; Fri, 24 Feb 2012 11:15:55 -0500 (EST) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1OGFrGH3485746 for ; Fri, 24 Feb 2012 11:15:54 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1OGFrC4017799 for ; Fri, 24 Feb 2012 14:15:53 -0200 Message-ID: <4F47B7B8.505@us.ibm.com> Date: Fri, 24 Feb 2012 10:15:52 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1330092792-22455-1-git-send-email-lcapitulino@redhat.com> <1330092792-22455-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Luiz Capitulino On 02/24/2012 10:12 AM, Peter Maydell wrote: > On 24 February 2012 14:13, Luiz Capitulino wrote: >> Perform the following renames: >> >> o qemu_register_machine() -> machine_register() >> o find_machine() -> machine_find() >> o find_default_machine() -> machine_find_default() >> >> Signed-off-by: Luiz Capitulino >> 52 files changed, 96 insertions(+), 96 deletions(-) > > I said I was going to nack the next change-whole-tree > change, so here it is: nack. > > At some point we're going to have to actually start > converting boards to be QOM objects themselves, but > (a) I hope we can make that incremental so we can do > things in batches the way we did with MemoryRegion > conversions and (b) until then the qemu_register_machine > rename just looks like unnecessary churn to me. I think I agree with you here. I don't see the value compared to the churn here given that we're going to have to touch all of this again anyway soon. Regards, Anthony Liguori > > -- PMM > >