From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0yJ1-0000xd-O8
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:47:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0yIx-0000hd-Et
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:47:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:65050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0yIx-0000hM-7B
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:47:35 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OGlXXb030901
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 24 Feb 2012 11:47:33 -0500
Message-ID: <4F47BF1A.3040603@redhat.com>
Date: Fri, 24 Feb 2012 17:47:22 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1330079874-5818-1-git-send-email-cfergeau@redhat.com>
In-Reply-To: <1330079874-5818-1-git-send-email-cfergeau@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] Add \n to the end of fatal spice error
 messages
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/24/12 11:37, Christophe Fergeau wrote:
> Without it the shell prompt doesn't appear on a new line after
> qemu dies.
> ---
>  ui/spice-core.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 1308a3d..6d240a3 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -568,15 +568,15 @@ void qemu_spice_init(void)
>      port = qemu_opt_get_number(opts, "port", 0);
>      tls_port = qemu_opt_get_number(opts, "tls-port", 0);
>      if (!port && !tls_port) {
> -        fprintf(stderr, "neither port nor tls-port specified for spice.");
> +        fprintf(stderr, "neither port nor tls-port specified for spice.\n");

Even better is this (no newline needed here):
  error_report("neither port nor tls-port specified fo  spice.");

>          exit(1);
>      }
>      if (port < 0 || port > 65535) {
> -        fprintf(stderr, "spice port is out of range");
> +        fprintf(stderr, "spice port is out of range\n");
>          exit(1);
>      }
>      if (tls_port < 0 || tls_port > 65535) {
> -        fprintf(stderr, "spice tls-port is out of range");
> +        fprintf(stderr, "spice tls-port is out of range\n");
>          exit(1);
>      }
>      password = qemu_opt_get(opts, "password");
> @@ -700,7 +700,7 @@ void qemu_spice_init(void)
>      qemu_opt_foreach(opts, add_channel, NULL, 0);
>  
>      if (0 != spice_server_init(spice_server, &core_interface)) {
> -        fprintf(stderr, "failed to initialize spice server");
> +        fprintf(stderr, "failed to initialize spice server\n");
>          exit(1);
>      };
>      using_spice = 1;