From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yXb-0006Gz-TR for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:02:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0yXX-0003Jx-It for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:02:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yXX-0003Jn-Av for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:02:39 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OH2c9n012176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Feb 2012 12:02:38 -0500 Message-ID: <4F47C2AC.3050009@redhat.com> Date: Fri, 24 Feb 2012 10:02:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <1329930815-7995-1-git-send-email-fsimonce@redhat.com> <1330102144-14491-1-git-send-email-fsimonce@redhat.com> In-Reply-To: <1330102144-14491-1-git-send-email-fsimonce@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB7238C5D45503AB4566967F3" Subject: Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Federico Simoncelli Cc: kwolf@redhat.com, armbru@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB7238C5D45503AB4566967F3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/24/2012 09:49 AM, Federico Simoncelli wrote: > From: Marcelo Tosatti >=20 > Mirrored writes are used by live block copy. >=20 > Signed-off-by: Marcelo Tosatti > Signed-off-by: Federico Simoncelli > --- > +++ b/block/blkmirror.c > @@ -0,0 +1,247 @@ > +/* > + * Block driver for mirrored writes. > + * > + * Copyright (C) 2011 Red Hat, Inc. It's 2012 now. > +++ b/docs/blkmirror.txt > @@ -0,0 +1,16 @@ > +Block mirror driver > +------------------- > + > +This driver will mirror writes to two distinct images. > +It's used internally by live block copy. > + > +Format > +------ > + > +blkmirror:/image1.img:/image2.img > + > +'\' (backslash) can be used to escape colon processing > +as a separator, in the first image filename. > +Backslashes themselves also can be escaped as '\\'. Is the escaping of : and \ only necessary for image1.img, or for both image1 and image2? I need to know if the parser is consistent for both arguments, but this wording makes it sound like it is only for the first argument. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigB7238C5D45503AB4566967F3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPR8KsAAoJEKeha0olJ0NqKoYH/38lw7I21e8NpIw17+7Evm1L OIZaSl8wE/01s0O/LfYVx3j+cePpsrBDAeOQKnfeQFO0Kx6e+kpGy7l3ayQaPhEO 1YAZSmqq+wfp28f60RuMV8VLk2QgmJ4eeoFVM5AEw0YUsDlnRuB8PfuLEVBa9pZN C87mGt2JAbV41cEp965NVi5g/2Nz9PWsCLGzR6YcJqZ3Y2z910WLkGgwMSBYPh5X ABPixRrjxS2olxh6BJ/0+5vNBN/f8l9v6o2cvGpte1u79RjFpY3wmyR31+vk0RVU 1r4dOs6Ao2DNp/IIwK+iKrbbaySlhVdnxGqHDi7bsqXeUNuS8ENKy55Epy7Db7g= =ssgQ -----END PGP SIGNATURE----- --------------enigB7238C5D45503AB4566967F3--