From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0ynl-0006BP-UC for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:19:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0ynk-0006Xq-Tn for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:19:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0ynk-0006Xj-MB for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:19:24 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OHJNn8005089 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Feb 2012 12:19:24 -0500 Message-ID: <4F47C699.60805@redhat.com> Date: Fri, 24 Feb 2012 18:19:21 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1330103593-11826-1-git-send-email-cfergeau@redhat.com> In-Reply-To: <1330103593-11826-1-git-send-email-cfergeau@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 1/2] spice: use error_report to report errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: qemu-devel@nongnu.org On 02/24/12 18:13, Christophe Fergeau wrote: > Error message reporting during spice startup wasn't consistent, it was done > with fprintf(stderr, "") but sometimes the message didn't have a trailing > \n. Using error_report make the intent of the message clearer and deal > with the final \n for us. Patch added to spice patch queue. thanks, Gerd