From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0yol-0007RN-S9
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:20:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0yoe-0006mb-GG
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:20:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S0yoe-0006mS-8j
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 12:20:20 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OHK2dQ005324
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 24 Feb 2012 12:20:08 -0500
Message-ID: <4F47C6C0.2040506@redhat.com>
Date: Fri, 24 Feb 2012 18:20:00 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1330103593-11826-1-git-send-email-cfergeau@redhat.com>
	<1330103593-11826-2-git-send-email-cfergeau@redhat.com>
In-Reply-To: <1330103593-11826-2-git-send-email-cfergeau@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2 2/2] Error out when tls-channel option is
 used without TLS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/24/12 18:13, Christophe Fergeau wrote:
> It's currently possible to setup spice channels using TLS when
> no TLS port has been specified (ie TLS is disabled). This cannot
> work, so better to error out in such a situation.

Applying: Error out when tls-channel option is used without TLS
=== checkpatch complains ===
WARNING: line over 80 characters
#12: FILE: ui/spice-core.c:531:
+            error_report("spice: tried to setup tls-channel without
specifying a TLS port\n");

total: 0 errors, 1 warnings, 19 lines checked

/tmp/tmp.9W76AGBT7O has style problems, please review.  If any of these
errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.