qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] converting the block layer from coroutines to threads
Date: Fri, 24 Feb 2012 13:22:34 -0600	[thread overview]
Message-ID: <4F47E37A.6000702@codemonkey.ws> (raw)
In-Reply-To: <4F47DEB1.7080009@redhat.com>

On 02/24/2012 01:02 PM, Paolo Bonzini wrote:
> Hi all,
>
> a few weeks ago Stefan Hajnoczi pointed me to his work on virtio-blk
> performance.
>
> Stefan's work had two sides.  First, he captured very nice performance
> data of the block layer at
> http://www.linux-kvm.org/page/Virtio/Block/Latency; second, in order to
> measure peak performance, he basically implemented "vhost-blk" in
> userspace.

I don't think the improvements here have anything to do with the block layer.

We've done the same thing with virtio-net and saw impressive performance results 
as a consequence.  Conversely, we see a similar improvement by applying the same 
technique to vhost-net.

Virtio really wants each virtqueue to be processed in a separate thread.  On a 
multicore system, there's considerable improvement doing this.

I think that's where we ought to start.  We really just need the block layer to 
be re-entrant, we don't actually need qcow2 or anything else that uses 
coroutines to use full threads.

Or at least, as far as I know, we don't have any performance data to suggest 
that we do.

Regards,

Anthony Liguori

  reply	other threads:[~2012-02-24 19:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24 19:02 [Qemu-devel] converting the block layer from coroutines to threads Paolo Bonzini
2012-02-24 19:22 ` Anthony Liguori [this message]
2012-02-24 20:43   ` Paolo Bonzini
2012-02-24 21:01     ` Anthony Liguori
2012-02-28  9:34       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F47E37A.6000702@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).