From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S12Kc-0007t9-6G for qemu-devel@nongnu.org; Fri, 24 Feb 2012 16:05:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S12Ka-00034i-Tz for qemu-devel@nongnu.org; Fri, 24 Feb 2012 16:05:33 -0500 Received: from mail-ey0-f173.google.com ([209.85.215.173]:40080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S12Ka-00034M-OF for qemu-devel@nongnu.org; Fri, 24 Feb 2012 16:05:32 -0500 Received: by eaan13 with SMTP id n13so749180eaa.4 for ; Fri, 24 Feb 2012 13:05:31 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F47FB99.3020401@redhat.com> Date: Fri, 24 Feb 2012 22:05:29 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1329930815-7995-1-git-send-email-fsimonce@redhat.com> <1330102144-14491-2-git-send-email-fsimonce@redhat.com> <20120224170143.78f55d3e@doriath.home> <4F47F3DE.7030208@redhat.com> <20120224183646.23d4902a@doriath.home> In-Reply-To: <20120224183646.23d4902a@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, Federico Simoncelli , mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 02/24/2012 09:36 PM, Luiz Capitulino wrote: > > > IMO, you could require the filename arguments to be escaped already. > > > > The monitor command was introduced exactly to avoid having to worry > > about details such as escaping. JSON is already supposed to take care > > of those. > > Then the escaping should be done by the parser, not by the command > implementation. This command is passing its arguments to the block layer, which needs its own escaping. It's a wart of the block layer and not supposed to percolate outside QEMU. Paolo