From: "Andreas Färber" <afaerber@suse.de>
To: Meador Inge <meadori@codesourcery.com>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
Date: Fri, 24 Feb 2012 23:53:43 +0100 [thread overview]
Message-ID: <4F4814F7.6040008@suse.de> (raw)
In-Reply-To: <1330121921-23462-1-git-send-email-meadori@codesourcery.com>
Am 24.02.2012 23:18, schrieb Meador Inge:
> Fixing a simple typo, s/errno/err/, that caused
> the error status from GDB semihosted system calls
> to be returned incorrectly.
>
> Signed-off-by: Meador Inge <meadori@codesourcery.com>
Nice catch!
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
> ---
> m68k-semi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/m68k-semi.c b/m68k-semi.c
> index bab01ee..6d60ced 100644
> --- a/m68k-semi.c
> +++ b/m68k-semi.c
> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
> }
> /* FIXME - handle put_user() failure */
> put_user_u32(ret, args);
> - put_user_u32(errno, args + 4);
> + put_user_u32(err, args + 4);
> }
>
> #define ARG(n) \
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-24 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 22:18 [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly Meador Inge
2012-02-24 22:53 ` Andreas Färber [this message]
2012-03-27 15:07 ` Meador Inge
2012-03-27 15:43 ` Peter Maydell
2012-03-27 15:51 ` Andreas Färber
2012-10-29 9:42 ` Peter Maydell
2012-10-29 10:03 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4814F7.6040008@suse.de \
--to=afaerber@suse.de \
--cc=meadori@codesourcery.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).