Re: [Qemu-devel] [PATCH] vnc: Add break statement

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On 02/25/2012 06:57 AM, Stefan Weil wrote:
> This was not a bug, but it is not common practice to omit the break statement
> from the last case statement before an empty default case.
> 
> Any change of the default case would introduce a bug.
> 
> This was reported as a warning by splint.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  ui/vnc-enc-hextile-template.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h
> index b9f9f5e..a7310e1 100644
> --- a/ui/vnc-enc-hextile-template.h
> +++ b/ui/vnc-enc-hextile-template.h
> @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
>  	    /* we really don't have to invalidate either the bg or fg
>  	       but we've lost the old values.  oh well. */
>  	}
> +        break;

TABs vs. space looks odd.  Does this file also need a whitespace cleanup?

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]