From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1ISD-0003Rm-Sd for qemu-devel@nongnu.org; Sat, 25 Feb 2012 09:18:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1IS9-0002yZ-Cl for qemu-devel@nongnu.org; Sat, 25 Feb 2012 09:18:29 -0500 Message-ID: <4F48EDA3.2080700@redhat.com> Date: Sat, 25 Feb 2012 07:18:11 -0700 From: Eric Blake MIME-Version: 1.0 References: <1330178223-31717-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1330178223-31717-1-git-send-email-sw@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig5CDFE87853B2A3826F56FAD8" Subject: Re: [Qemu-devel] [PATCH] vnc: Add break statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Trivial , Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5CDFE87853B2A3826F56FAD8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/25/2012 06:57 AM, Stefan Weil wrote: > This was not a bug, but it is not common practice to omit the break sta= tement > from the last case statement before an empty default case. >=20 > Any change of the default case would introduce a bug. >=20 > This was reported as a warning by splint. >=20 > Signed-off-by: Stefan Weil > --- > ui/vnc-enc-hextile-template.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >=20 > diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-templat= e.h > index b9f9f5e..a7310e1 100644 > --- a/ui/vnc-enc-hextile-template.h > +++ b/ui/vnc-enc-hextile-template.h > @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncSta= te *vs, > /* we really don't have to invalidate either the bg or fg > but we've lost the old values. oh well. */ > } > + break; TABs vs. space looks odd. Does this file also need a whitespace cleanup?= --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig5CDFE87853B2A3826F56FAD8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPSO2kAAoJEKeha0olJ0NqessH/is5vHDMHuE55oe5H8XE7N32 FFvBVr13jYByr+FT3MtPR4cnON/O2T0B//1+6shuE8fCpvhoUStf5OTYORyL33rp JYexTmKpjSOMgEwmchuolD+86JocrcI/9Ho8gliZ8MsI99OOtLJstCBOyYJPb+w9 oQpQbiwvOORNRs64/ba2pAmXQSMZmbpvOvGwOqbMRaF0BisHB0wx6g8ot3PbzBfr nGvQxBdIafn7bV5oR4Xqgw5uyyO7p3fKPWTneFYEb2NpsqVGSpEI7XfiRe+WiICe OY0EAXJXtVjJUcSrizGitkqiyugmHOw+kuIkEpYWfMlUYqeYLMC1GapY6+0nK88= =XZa9 -----END PGP SIGNATURE----- --------------enig5CDFE87853B2A3826F56FAD8--