From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1K0C-000258-20 for qemu-devel@nongnu.org; Sat, 25 Feb 2012 10:57:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1K04-0008P1-4i for qemu-devel@nongnu.org; Sat, 25 Feb 2012 10:57:39 -0500 Message-ID: <4F4904EA.5050002@suse.de> Date: Sat, 25 Feb 2012 16:57:30 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1330178223-31717-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1330178223-31717-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vnc: Add break statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Trivial , Anthony Liguori , qemu-devel@nongnu.org Am 25.02.2012 14:57, schrieb Stefan Weil: > This was not a bug, but it is not common practice to omit the break sta= tement > from the last case statement before an empty default case. >=20 > Any change of the default case would introduce a bug. >=20 > This was reported as a warning by splint. >=20 > Signed-off-by: Stefan Weil > --- > ui/vnc-enc-hextile-template.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >=20 > diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-templat= e.h > index b9f9f5e..a7310e1 100644 > --- a/ui/vnc-enc-hextile-template.h > +++ b/ui/vnc-enc-hextile-template.h > @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncSta= te *vs, > /* we really don't have to invalidate either the bg or fg > but we've lost the old values. oh well. */ > } > + break; > default: Doesn't that require a fallthrough comment for other tools then? Andreas > break; > } --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg