From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S1KBv-00055Y-DB
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:09:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S1KBp-0001cz-9h
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:09:47 -0500
Message-ID: <4F4907C2.2080402@weilnetz.de>
Date: Sat, 25 Feb 2012 17:09:38 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1330178223-31717-1-git-send-email-sw@weilnetz.de>
	<4F4904EA.5050002@suse.de>
In-Reply-To: <4F4904EA.5050002@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] vnc: Add break statement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 25.02.2012 16:57, schrieb Andreas F=E4rber:
> Am 25.02.2012 14:57, schrieb Stefan Weil:
>> This was not a bug, but it is not common practice to omit the break=20
>> statement
>> from the last case statement before an empty default case.
>>
>> Any change of the default case would introduce a bug.
>>
>> This was reported as a warning by splint.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> ui/vnc-enc-hextile-template.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/ui/vnc-enc-hextile-template.h=20
>> b/ui/vnc-enc-hextile-template.h
>> index b9f9f5e..a7310e1 100644
>> --- a/ui/vnc-enc-hextile-template.h
>> +++ b/ui/vnc-enc-hextile-template.h
>> @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_,=20
>> NAME)(VncState *vs,
>> /* we really don't have to invalidate either the bg or fg
>> but we've lost the old values. oh well. */
>> }
>> + break;
>> default:
>
> Doesn't that require a fallthrough comment for other tools then?
>
> Andreas

It was a fall through (so a comment would have satisfied static code
analyzers), but with the added 'break' it no longer is.

As I tried to explain in the commit message, a fall through would
not be reasonable in this special case.

Cheers, Stefan